codeql-action icon indicating copy to clipboard operation
codeql-action copied to clipboard

Failure doesn't show as failure

Open TWiStErRob opened this issue 11 months ago • 1 comments

We have a step that uses upload-sarif. It ran on merge_group: but failed because the merge queue item was removed from the queue. This resulted in the following error message (which seems normal, branch is deleted by removal from queue):

Image

Notice that somehow the step is still shown as successful, and yet the step failed because the next step had a condition to run if it failed. I'm wondering if there's something missing from the upload-sarif to make the "Publish" step red cross too, or this is maybe a GHA UI glitch.

TWiStErRob avatar Jan 14 '25 10:01 TWiStErRob

That indeed does seem weird. Could you maybe chime in @shaikhul?

redsun82 avatar Jan 14 '25 14:01 redsun82