Overflowing pickle write buffer as set in src/backends/carbon.h

Open deanbittner opened this issue 9 years ago • 2 comments

The default setting --

define PICKLE_BUFFER_SIZE 4096

Is too small, at least for me. I overflow it. I've built with a larger buffer, 16384, and no issues after that. The observed symptom is that all metrics are not visible and present in whisper, Graphite and downstream when I overwrite this buffer.

Sep 08 '16 16:09 deanbittner

I'm not sure I understand the issue here; the buffer is checked for capacity before pushing new pickles, so it should not be possible to overflow it. Can you provide a reproduction recipe?

Sep 09 '16 08:09 vmg

Yes, I see that now ... I will take a closer look and see if I can get a test case going.

Sep 09 '16 15:09 deanbittner