brubeck icon indicating copy to clipboard operation
brubeck copied to clipboard

Implements Carbon namespacing

Open alindeman opened this issue 10 years ago • 6 comments

statsd supports namespacing. For instance with a global namespace of stats and a counter namespace of counters, all counters would be namespaced as stats.counters.foo.

This PR implements statsd's namespacing logic (except for legacy namespacing, which I don't think we should be encouraging) in brubeck. Namespacing is not enabled by default, but can be configured in config.json.

Feedback welcomed :green_heart:

alindeman avatar Dec 20 '15 15:12 alindeman

For what it's worth, I have tested this pull request and it worked for me.

If you want to use carbon-namespacing then add the following options to your backend type carbon:

      "global_prefix" : "stats",
      "prefix_counter" : "counters",
      "prefix_timer" : "timers",
      "prefix_histo" : "histos",
      "prefix_gauge" : "gauges"

blak3r2 avatar Oct 29 '16 23:10 blak3r2

+1

eugenepaniot avatar Nov 15 '16 15:11 eugenepaniot

@vmg @carlosmn this works for us as well. Merge?

StevenACoffman avatar Mar 29 '17 15:03 StevenACoffman

Is this dead? :)

ghost avatar Aug 30 '17 02:08 ghost

Generally speaking, we don't merge any features which we don't actively use in GitHub because we're afraid of unexpected side effects. This PR looks correct, however. If you really need this feature I'd advise you to carry this patch on a fork of brubeck.

vmg avatar Aug 30 '17 07:08 vmg

we don't merge any features which we don't actively use in GitHub because we're afraid of unexpected side effects

@vmg Why even bother open sourcing this then?

haggy avatar Aug 26 '19 18:08 haggy