branch-deploy icon indicating copy to clipboard operation
branch-deploy copied to clipboard

Add an option to fail on a skipped check

Open adajou opened this issue 11 months ago • 4 comments

Details

We have a scenario where we want to skip a certain check for the development environment but not for stage and production. With the current setup (as I understand it from looking at the code here link) skipped check is considered healthy. It would be convient for us to have an option like skipped_checks: true/false (fail if it is set to false as we would like it to be here)

adajou avatar Apr 08 '25 08:04 adajou

👋 Hey @adajou! Currently, all of the checks input options apply across all environments. There isn't a way to have a check be skipped in one environment, but not another.

I'm open to pull requests for this feature but it isn't something that I have immediate time to work on right now.

GrantBirki avatar Apr 08 '25 16:04 GrantBirki

Hi @GrantBirki, thanks for the reply. I will take a look at the possibility of creating a PR for this

adajou avatar Apr 09 '25 07:04 adajou

This pull request has some prior context as well: https://github.com/github/branch-deploy/pull/337

GrantBirki avatar Apr 09 '25 23:04 GrantBirki

This is what i'm using at the moment as a workaround. Passing all the checks needed for a specific environment. But having the ability to fail on skipped checks would make it much easier. I will propose a PR for this

adajou avatar Apr 10 '25 08:04 adajou