github icon indicating copy to clipboard operation
github copied to clipboard

Enable to pass an object to createBlob

Open dudaerich opened this issue 7 years ago • 4 comments

createBlob automatically encodes string parameter by Utf8 library. In some cases the string value can be already encoded in Utf8 so the encoding should be skipped.

This commit enables to pass object containing the content and encoding items. This object is directly sent to Github. Users have better control about what is actually sending.

closes #463

dudaerich avatar Jul 27 '17 16:07 dudaerich

This definitely seems like an important issue. @dudaerich Would you be able to write a test that demonstrates the issue you've run into?

j-rewerts avatar Apr 07 '19 23:04 j-rewerts

@j-rewerts sure. You can find it in this commit.

dudaerich avatar Apr 08 '19 19:04 dudaerich

Could you put that on your issue-463 branch?

j-rewerts avatar Apr 09 '19 01:04 j-rewerts

Done. I updated the test to use the object type. Otherwise it would still fail.

To be honest, I am not very convinced that my fix is right. Its advantage is that is backward compatible. On the other hand it is quite unexpected that this test fails. IMO the library shouldn't encode strings to UTF-8. On most platforms UTF-8 is default encoding so it doesn't make sense to encode already encoded strings. If someone uses more exotic encoding, they can encode it to UTF-8 before they pass it to the library. Wdyt?

dudaerich avatar Apr 09 '19 18:04 dudaerich