github icon indicating copy to clipboard operation
github copied to clipboard

refactor: Repository.move filters nodes instead of deleting their sha

Open AurelioDeRosa opened this issue 9 years ago • 2 comments

closes #215

AurelioDeRosa avatar Jun 20 '16 10:06 AurelioDeRosa

@clayreimann do you know why the build keeps failing?

AurelioDeRosa avatar Jun 20 '16 10:06 AurelioDeRosa

They need better isolation. The tests are pretty fragile, if you look at the build logs for each build that fails they all fail in different ways. Perhaps we just need to slow them down further (maybe 300-400ms between calls), but I think the thing we can do for the tests is to make sure that each test can run independently–so remove cross-test dependencies–and set mocha to retry failed tests a couple times. I've often found that running a build a second time will result in the build passing.

Also, we should update travis.yml to only build master and the tags, as in this example. That way PRs like this one don't kick off two different builds.

clayreimann avatar Jun 20 '16 14:06 clayreimann