github-release-notes icon indicating copy to clipboard operation
github-release-notes copied to clipboard

`gren changelog` not finding all releases

Open paul-uz opened this issue 2 years ago • 4 comments

I have a private repo with 40+ releases, but running gren changelog only finds 30 releases.

All releases follow the same versioning format, x.y.z

paul-uz avatar Nov 23 '21 17:11 paul-uz

I tried with --limit 100 but the debug info still says 30

gren changelog -o -D prs --limit 100 -B

Options: 
Tags: empty
Prefix: empty
Template: [object Object]
Prerelease: false
Generate: false
Quiet: false
Override: true
Debug: true
Ignore labels: empty
Ignore issues with: empty
Ignore commits with: empty
Group by: false
Milestone match: Release {{tag_name}}
Changelog filename: CHANGELOG.md
Username: Foobar
Repo: XYZ
Token: XXX
Limit: 30
Data source: prs
Include messages: commits
Ignore tags with: empty

paul-uz avatar Nov 23 '21 17:11 paul-uz

Limit does work, for numbers <= 99. As soon as you try 100, it defaults back to 30

paul-uz avatar Nov 23 '21 18:11 paul-uz

That is, because there is a MAX_TAGS_LIMIT = 99 in https://github.com/github-tools/github-release-notes/blob/master/lib/src/Gren.js. If you go beyond that, it will revert to the default TAGS_LIMIT = 30.

mv-coder avatar Nov 26 '21 10:11 mv-coder

Well, thats a bit daft isn't it. And not mentioned in the documentation 🙄

paul-uz avatar Nov 26 '21 11:11 paul-uz