github-release-notes icon indicating copy to clipboard operation
github-release-notes copied to clipboard

Incorrect logic in release note creation

Open patrickallaert opened this issue 5 years ago • 3 comments

Hi,

I have used gren for both creating changelog file and generating release notes on the GH releases and have the same wrong results in both cases:

# Changelog

## v1.0.7 (29/09/2020)
*No changelog for this release.*

---

## v1.0.6 (29/09/2020)
*No changelog for this release.*

---

## v1.0.5 (29/09/2020)
*No changelog for this release.*

---

## v1.0.4 (29/09/2020)
*No changelog for this release.*

---

## v1.0.3 (29/09/2020)
*No changelog for this release.*

---

## v1.0.2 (29/09/2020)
*No changelog for this release.*

---

## v1.0.1 (29/09/2020)
*No changelog for this release.*

---

## v1.0.0 (29/09/2020)
- List of all the 95 PRs we have.

So instead of spreading the 95 PRs in their correct releases, they have all been linked to v1.0.0 (which should just have a few).

I guess this is because the tags/releases have not been created at the time of the commit they are referring to. They have all been created today Sep 29th 2020, but each of them correctly points to the right sha1.

If that is the case, I think that being time-based is not a very robust approach, however it should at least be based on the date of the commit the tag is referring to and not the tag's date.

patrickallaert avatar Sep 29 '20 10:09 patrickallaert

:+1:

bjhartin avatar Jan 20 '21 23:01 bjhartin

Good point. This is going to the Massive refactor milestone :)

alexcanessa avatar Mar 25 '21 10:03 alexcanessa

@patrickallaert Do the changes I made in my fork fix your problem?

https://github.com/cjbarth/github-release-notes/releases/tag/0.18.0

cjbarth avatar Sep 25 '21 02:09 cjbarth