Request for support for issues closed with keywords in non-master branch.

[kimmo-steleco]

Reference: GitHub: Closing issues using keywords

If you use one of GitHub's keywords for closing an issue in a branch then the issue is marked for closing when the branch is merged with master.

Note: I'm using git flow. So if i'm working in hotfix/1.0.6 based on master. And commit with the message Resolved #12 .... and push it. Then the issue is marked for closing when the branch is merge into master. When i finish the branch with git flow hotfix finish 1.0.6 it tags the last commit with 1.0.6 and merges it into master. When i then run gren r I don't get #12 in my release notes. In fact since I'm always doing this all my release notes end up on the next tag instead...

Seems to me like this is an issue of < instead of <=.

[alexcanessa]

Interesting, I'll have a look and see what could be the problem

[iamjoeker]

I encountered this today. The issue is with the issue filter logic here: https://github.com/github-tools/github-release-notes/blob/56551aef2ed2c569bdf0f74459db5de56376a313/lib/src/Gren.js#L849-L859

It assumes that closed_at for the issue will be before the tag timestamp—which is not the case if you use this workflow. Here are some examples from my repo where I'm starting to use gren. There should have been ~25 issues in my release but only 1 appeared (because it was manually closed).

id: 18 closed: 2018-05-09T02:08:40Z [1]: Wed Dec 31 1969 18:00:00 GMT-0600 (CST) [2]: 2018-05-09T02:08:38Z
id: 17 closed: 2018-05-09T02:08:40Z [1]: Wed Dec 31 1969 18:00:00 GMT-0600 (CST) [2]: 2018-05-09T02:08:38Z
id: 16 closed: 2018-05-09T02:08:41Z [1]: Wed Dec 31 1969 18:00:00 GMT-0600 (CST) [2]: 2018-05-09T02:08:38Z
id: 15 closed: 2018-05-07T20:38:29Z [1]: Wed Dec 31 1969 18:00:00 GMT-0600 (CST) [2]: 2018-05-09T02:08:38Z
id: 14 closed: 2018-05-09T02:08:41Z [1]: Wed Dec 31 1969 18:00:00 GMT-0600 (CST) [2]: 2018-05-09T02:08:38Z