Replace Nextflow grammar and change colour
Description
This PR updates configuration for the Nextflow language:
- Update the grammar repository
- Update the color to match Nextflow branding
- Update code samples to match current syntax
cc @ewels
Checklist:
-
[x] I am changing the source of a syntax highlighting grammar
- Old: https://github.com/nextflow-io/atom-language-nextflow
- New: https://github.com/nextflow-io/vscode-language-nextflow
-
[x] I am changing the color associated with a language
- [x] I have obtained agreement from the wider language community on this color change.
- https://brand.seqera.io/color
- [x] I have obtained agreement from the wider language community on this color change.
The link supporting the discussion in the template for the colour change needs to be an actual community discussion where the wider community has agreed on the change, not a link to the branding.
The color change was made by Seqera, the company that owns Nextflow, so there is no community discussion for this. You can see this new color reflected in the GitHub repository and website
I reverted the samples and updated the license. I had trouble running the add-grammar tool, possibly because it didn't seem to recognize the old atom-language-nextflow submodule. Maybe because the repo is archived? In any case, I have tried to update everything manually to the best of my ability.
The color change was made by Seqera, the company that owns Nextflow, so there is no community discussion for this. You can see this new color reflected in the GitHub repository and website
That may be the case but this is about changing the colour on GitHub. People get very sensitive about simple things like this, even when the language creators make these decisions, and we need somewhere to direct them when they come asking.
In that case the brand website or Nextflow website should be enough... any community discussion at this point would be kind of moot given that we've already changed the color everywhere else
@ewels do you have any ideas here? I don't know what else we can do
Crikey, this was a while ago. I think the official announcement was in 2023, see this blog post.
The main place for community discussion is now https://community.seqera.io/tag/nextflow , but we launched that around the same time that the colour and logo changed, so I don't think that there are any posts on this topic or anything. The repo with the trademark and official logos (with the colour) is here: https://github.com/nextflow-io/trademark
There's plenty of evidence of community adoption of the new logo and colour. The simplest way to see this is to search for "Nextflow" on Google Images and filter for the past year. Basically everything uses the new colour.
Is this enough @lildude? If you can think of anything else specific that you'd like to see I can try to dig something up.
Thanks @ewels. I'll take that as sufficient evidence. If anyone complains, I'll send them your/Seqera's way 😉
I had trouble running the
add-grammartool, possibly because it didn't seem to recognize the old atom-language-nextflow submodule. Maybe because the repo is archived? In any case, I have tried to update everything manually to the best of my ability.
Yeah, so that doesn't look like it's worked given the test failures. The fact the original repo is archived doesn't matter as we don't reach out to it when replacing the grammar.
If anyone complains, I'll send them your/Seqera's way 😉
Absolutely, happy to take the blame! 😅 Thanks!