linguist icon indicating copy to clipboard operation
linguist copied to clipboard

Replace Just grammar

Open nefrob opened this issue 1 year ago • 6 comments

Description

Update just language grammar to use maintained https://github.com/nefrob/vscode-just. This has been updated as the suggested vscode extension by the just language repo here: https://github.com/casey/just?tab=readme-ov-file#visual-studio-code.

Checklist:

  • [x] I am changing the source of a syntax highlighting grammar
    • Old: https://github.com/skellock/vscode-just
    • New: https://github.com/nefrob/vscode-just

nefrob avatar Aug 11 '24 13:08 nefrob

🤔 Did you use the script/add-grammar script to replace the grammar?

lildude avatar Aug 12 '24 05:08 lildude

🤔 Did you use the script/add-grammar script to replace the grammar?

@lildude I tried doing

script/add-grammar --replace vscode-just https://github.com/nefrob/vscode-just

per the contributing guidelines and it failed to find the submodule. I then did

script/add-grammar --replace vendor/grammars/vscode-just https://github.com/nefrob/vscode-just

but it deleted all the license files and readme entries for other languages, and failed to update the license file for vscode-just.

Screenshot 2024-08-12 at 9 00 19 AM

So I opted to try and manually edit the same files the script seemed to be modifying. Is there a different way to do this?

nefrob avatar Aug 12 '24 15:08 nefrob

@lildude I tired doing

script/add-grammar --replace vscode-just https://github.com/nefrob/vscode-just

Can you please provide the output from this. This is the correct command so should work. The script hasn't been touched in a while so it's possible some sort of Git change has caught us off guard.

lildude avatar Aug 12 '24 16:08 lildude

Ooo, I think I might have hit the issue in as much as I don't get an error, but it doesn't switch the grammar either. Looks like something is caching somewhere. Lemme dig into it.

lildude avatar Aug 12 '24 16:08 lildude

Got it. For some reason the .git/modules/vendor/grammars/vscode-just directory isn't being removed. I'm not sure why but there's no harm manually removing it. I'll update the script and also push the update of the grammar to this PR.

lildude avatar Aug 12 '24 16:08 lildude

@lildude thanks for the assist!

nefrob avatar Aug 12 '24 16:08 nefrob