linguist icon indicating copy to clipboard operation
linguist copied to clipboard

Add the Cylc language.

Open oliver-sanders opened this issue 1 year ago • 3 comments

Description

Add the Cylc language.

Checklist:

  • [x] I am adding a new language.
    • [x] The extension of the new language is used in hundreds of repositories on GitHub.com.
    • [x] I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • https://github.com/MetOffice/CSET/blob/main/cset-workflow/flow.cylc
        • https://github.com/MetOffice/CSET/tree/main/cset-workflow/includes
      • Sample license(s):
        • Apache 2.0
    • [x] I have included a syntax highlighting grammar: Cylc.tmbundle (BSD)
    • [x] I have added a color
      • Hex value: #00b3fd
      • Rationale: Primary brand colour used in user interfaces and the logo.
    • [ ] I have updated the heuristics to distinguish my language from others using the same extension.
      • No other languages share the ".cylc" extension.

oliver-sanders avatar May 16 '24 11:05 oliver-sanders

Just checking in to see if there's anything I can do to help move this forward.

Does the "pending popularity" label mean that we are pending a popularity check by reviewers, or does it mean that the project hasn't yet met the popularity requirements?

oliver-sanders avatar Aug 08 '24 13:08 oliver-sanders

Does the "pending popularity" label mean that we are pending a popularity check by reviewers, or does it mean that the project hasn't yet met the popularity requirements?

It means, based on the results from the search query provided in the PR template, at the time the PR was first checked, there were insufficient files for this language detected on GitHub for it to meet our requirements for inclusion.

This is reassessed whenever a new release is being constructed.

Just checking in to see if there's anything I can do to help move this forward.

Only 🤞 that things improve in popularity in time for the new release 😁

lildude avatar Aug 08 '24 14:08 lildude

Great, thanks for the clarification.

The extension usually only appears once per repo so I used a search query which looks for files in the project root which has ~800 results (above the 200 threshold). I failed to mention it was a "once per repo" query, apologies.

I've now also included file extension queries (which will also pick up include files) which gives ~2.4k matches.

Advice for identifying Cylc files
Cylc files will generally start with one of the following:
  • [cylc]
  • [scheduling]
  • [meta]
  • [runtime]
  • [task parameters]
  • #!Jinja2
  • #!EmPy
  • %include
  • {% include ...

oliver-sanders avatar Aug 08 '24 15:08 oliver-sanders