linguist icon indicating copy to clipboard operation
linguist copied to clipboard

Add Glimmer TS language

Open gilest opened this issue 1 year ago • 5 comments

Description

Adds support for TypeScript-flavoured Glimmer.js which will be the component authoring format of the next Edition of Ember.js.

Checklist:

  • [x] I am adding a new language.
    • [x] The extension of the new language is used in hundreds of repositories on GitHub.com.
      • Search results for each extension:
    • [x] I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
      • Sample license(s):
        • class.gts -(https://github.com/cardstack/cardstack) MIT
        • template-only.gjs (https://github.com/CrowdStrike/opensource.crowdstrike.com) MIT
    • [x] I have added a color
      • Hex value: #3178c6
      • Rationale: TypeScript colour which is also used by TypeScript and TSX
    • [x] I have updated the heuristics to distinguish my language from others using the same extension.

gilest avatar Jan 17 '24 04:01 gilest

CI is failing because the vscode-vba repo has been removed from GitHub

gilest avatar Jan 17 '24 04:01 gilest

All should be good now I've merged https://github.com/github-linguist/linguist/pull/6678

lildude avatar Jan 17 '24 11:01 lildude

Is this able to be merged? Reviewing our gts files in PRs is a nightmare at the moment 🙏

deanylev avatar Jan 30 '24 12:01 deanylev

Is this able to be merged? Reviewing our gts files in PRs is a nightmare at the moment 🙏

Appreciate your anticipation @deanylev

According to the Lingust docs

Changes to Linguist will only appear on GitHub when a new Linguist release is made and this is deployed to GitHub.com. There is no set release timeframe, but the intention is at least once every three-to-four months...

So even if this PR is merged, we'll be waiting for the next Lingust release which may be in March/April 🙂

gilest avatar Jan 30 '24 21:01 gilest

Looking forward to this as well. For what it's worth, we have 300+ GTS files in a private repo.

Techn1x avatar Feb 08 '24 07:02 Techn1x