private-mirrors icon indicating copy to clipboard operation
private-mirrors copied to clipboard

feat: add docker publish workflow

Open jonathanmorley opened this issue 1 year ago • 2 comments

Pull Request

Proposed Changes

This adds a workflow that will publish the docker images (x86 and arm64) to ECR.

Notes:

  • It assumes the existence of a ubuntu-22.04-medium-arm64 runner, which is non-standard
  • It currently needs to be manually invoked

Readiness Checklist

Author/Contributor

  • [ ] If documentation is needed for this change, has that been included in this pull request
  • [ ] run npm run lint and fix any linting issues that have been introduced
  • [ ] run npm run test and run tests
  • [ ] If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • [ ] Label as either bug, documentation, enhancement, infrastructure, maintenance, or breaking

jonathanmorley avatar Sep 24 '24 13:09 jonathanmorley

Requesting review from @jeffrey-luszcz

jonathanmorley avatar Sep 24 '24 13:09 jonathanmorley

This does support version numbered containers. See https://github.com/cvent/private-mirrors/actions/runs/11014902329 where I passed in a value of 0.20.0, and it was used as the label of the container, producing https://github.com/cvent/private-mirrors/pkgs/container/private-mirrors/278597478?tag=0.20.0

As mentioned in a comment, ideally this would be attached to the release workflow to auto-publish with the right version number

jonathanmorley avatar Sep 30 '24 13:09 jonathanmorley

Superseded by #302, thanks @jmeridth !

ahpook avatar Jan 24 '25 22:01 ahpook