lotr-api icon indicating copy to clipboard operation
lotr-api copied to clipboard
verified publisher icon gitfrosh

Add Tests

Open gitfrosh opened this issue 4 years ago • 4 comments

This Repo is entirely non-tested. 😭 Pull requests including

  • a CRA / jest / react-testing-library setup and some unit tests for the frontend
  • a test setup for the backend

are very welcome.

gitfrosh avatar Mar 03 '21 16:03 gitfrosh

Hey, I might look into backend tests. I already added few in my other PR and can continue working on that.

MateuszKikmunter avatar Jan 31 '22 22:01 MateuszKikmunter

Once the tests are in we should look at adding some basic CI, either with GitHub Actions/CircleCI/Travis or something similar. It would help a lot with reviewing future PRs.

EddieEldridge avatar Feb 01 '22 09:02 EddieEldridge

Agree, it would be beneficial. Maybe it's worth to create another issue?

MateuszKikmunter avatar Feb 01 '22 10:02 MateuszKikmunter

Agree, it would be beneficial. Maybe it's worth to create another issue?

Yep, good idea. See https://github.com/gitfrosh/lotr-api/issues/54

EddieEldridge avatar Feb 01 '22 10:02 EddieEldridge

Added frontend tests and now api finally should have a valuable suite of tests. (unit for now) I'm closing this issue as with this PR we have enough tests at the moment.

MateuszKikmunter avatar May 09 '24 21:05 MateuszKikmunter