csv-to-sql-insert icon indicating copy to clipboard operation
csv-to-sql-insert copied to clipboard

prettier and eslint config for the project

Open YugandharrPatil opened this issue 1 year ago • 5 comments

I think adding a prettier and eslint config for the project would be ideal since varying configs of users can make it difficult for changes to be analyzed in PRs.

YugandharrPatil avatar Dec 22 '23 17:12 YugandharrPatil

This is a good idea and one I'd like to prioritize so all the PRs aren't formatted differently.

gitdagray avatar Dec 22 '23 17:12 gitdagray

Prettier config now added - see dev dependencies in package.json. Guide for this update here: https://gist.github.com/siakaramalegos/4a5cdab1f44ffb217a48d5260043f8ae

eslint config still needed - leaving this issue open.

gitdagray avatar Dec 22 '23 18:12 gitdagray

how about we go with the infamous airbnb config? Here's the style guide: https://github.com/airbnb/javascript

YugandharrPatil avatar Dec 22 '23 18:12 YugandharrPatil

how about we go with the infamous airbnb config? Here's the style guide: https://github.com/airbnb/javascript

Yes, I've looked at that in the past. Please do. 😀

gitdagray avatar Dec 22 '23 18:12 gitdagray

How about we populate the prettier config? Because it'll keep giving errors until we populate it with something. Safe to close the issue after its addition I guess.

YugandharrPatil avatar Dec 23 '23 03:12 YugandharrPatil