korrrba

Results 42 comments of korrrba

> ```diff > ! Too many assigned issues, you have reached your max limit > ``` Interesting, I received a notification in the pull request that bot unassigned me, so...

Perhaps solhint or https://github.com/solhint-community/solhint-community fork could be integrated after all rules are agreed: Example settings: https://github.com/PaulRBerg/foundry-template/blob/main/.solhint.json There are differences in so called 'best practices' rules, it would be good to...

I see some files can be removed from the pull request, will try to process them today.

I extracted this to a separate issue, will post finding for both `uad-contracts` and diamond-based staking contract.

This pull request is still a draft. It contains a skeleton for fuzz tests, I will keep updating and hopefully make as ready for review during or after the weekend.

I am playing with the fuzzer a lot and discovered an interesting case. When redeem threshold is set to $0.99 , the curve price must be larger than 990000999999999999 due...

I will finish with the whole test suite till Friday EOD and set the pr as ready for review.

I pushed the remaining fuzz tests also for redemption delay, setting as ready for review now.

> @gitcoindev > > 1. Could you add 2 more fuzz tests: > a) If user mints X Dollars he gets exactly X Dollars (minus fee) > b) If user...

Hi @rndquu @0x4007 @molecula451 the PR is ready to review, I executed QA against my fork: https://github.com/gitcoindev/ubiquity-dollar/actions/runs/9534134896/job/26278201422 . The CI setup is ready and according to the original spec. Fuzz...