web icon indicating copy to clipboard operation
web copied to clipboard

Published 20 hours ago • verified publisher icon gitcoinco

Preview of bounty details page

Open GTChase opened this issue 2 years ago • 9 comments

Acceptance Criteria Rendering Initiation GIVEN I am creating a bounty WHEN I navigate to the last step "Review Bounty" THEN I should see a rendering of what the bounties detail page would look like given the information have inputted on all previous steps AND it should include the new design and new fields

Product & Design Links:

GTChase avatar Apr 28 '22 17:04 GTChase

@nutrina Here is the new issue for the proper rendering of the preview.. WIll agreed it should be the new details page.

@willsputra could you put the new designs here in the product and designs link when that is ready?

GTChase avatar Apr 28 '22 17:04 GTChase

@willsputra if the design is the same as for the details page, I could just use that as reference

nutrina avatar May 02 '22 09:05 nutrina

Page has been reworked, the same design as for the bounty details page is being used now.

nutrina avatar May 03 '22 09:05 nutrina

Three minor issues here.. When set to never expire the Estimated Payout Date is showing 265 years lol. We should also consider the implications of what that means for Submission cutoff date when it is set to never expire.

The section for bounty owners display, but none of the bounty owners are showing. For this scenario, i have selected "Root" as a bounty owner. I would expect to see both myself as the creator and root in the bounty owner section, but neither are showing.

Also, if i dont enter any contact information, lets hide that section all together here and on the details page.. Right now it shows the discord logo with nothing.

Cc. @nutrina - moving back to todo to fix these issues.

Screen Shot 2022-05-03 at 3 44 41 PM

GTChase avatar May 03 '22 19:05 GTChase

Fixes are on their way

nutrina avatar May 04 '22 07:05 nutrina

Clarification: yes, add the bounty creator as the owner in the details page.

nutrina avatar May 04 '22 13:05 nutrina

Changes have been implemented, deployment is pending

nutrina avatar May 04 '22 18:05 nutrina

Looks like the dates for submission cut off date and estimated payout date are broken again.. I have both set to a month from today and when you go to preview page, both are showing as 3 months away. This issue persists on the details page as well.

Screen Shot 2022-05-09 at 10 57 24 AM Screen Shot 2022-05-09 at 10 57 34 AM

When set to never expires, all looks well.. cc. @nutrina

GTChase avatar May 09 '22 14:05 GTChase

Looks like the dates for submission cut off date and estimated payout date are broken again.. I have both set to a month from today and when you go to preview page, both are showing as 3 months away. This issue persists on the details page as well.

Looks like it's fixed? tried out two weeks and 1 year and it looks fine http://gitcoin-review-10409-a81235f-1873182368.us-west-2.elb.amazonaws.com/issue/16

lgtm!

willsputra avatar May 10 '22 14:05 willsputra