web
web copied to clipboard
gitcoinco
Select a payout token
User Story: As a funder I want to select a token from a list of tokens that are available from the selected payout chain So that i can only select tokens that can be paid out on my chain
Acceptance Criteria
Drop Down Initiation GIVEN I am adding payment details on the bounty creation wizard AND i have selected a chain WHEN I open the now enabled token drop down THEN i will see a list of tokens that I can payout on specific to the selected chain
Selecting a token GIVEN I am adding payment details on the bounty creation wizard AND i have selected a chain WHEN i select a token from the predefined list THEN the dropdown will close AND the amount field will now be enabled (funcitonality for amount will be handled in seperate story
Product & Design Links:
Tech Details:
Open Questions:
Notes/Assumptions:
This is close, just one minor update needed..
When selecting a token, the default value of amount should be 0.. Right now when I selected.. Chain = Eth, Token defaults = Eth, the field becomes enabled and automatically populates .69 for the USD amount.
For when this is wrapped up, is there a way to associate different tokens to the chains I can test the scenario of only showing the right tokens for the right chain.. Right now only ETH has tokens.
Would the duplicated tokens be gone in production? Right now I'm seeing two ETH and DAI
@nutrina - this question stands for me as well.. Im assuming the list of tokens is wonky because it being bad data.. is that fair? If so, we can close this story!
@GTChase @willsputra This is due to the faulty configuration of the tokens in the DB, I have fixed this.
BUT .... the token list that is displayed depends on the chain (mainnet, rinkeby, harmony mainnet, etc ...) to which the user is connected and if he is connected. Not sure if this is obvious enough for the user, for example if the user would want to pay out using ONE tokens, is it obvious what to do? @willsputra I think we need your input here
We have removed the step that would prompt the user to connect to the wallet when selecting ETH (this made it more obvious), but we should keep in mind that if want to test on testnets, we will need to switch to a testnet before selecting the token.
I mean if they wanted to payout using ONE, they would just select harmony. .That feels obvious.. @willsputra what are your thoughts?
BUT .... the token list that is displayed depends on the chain (mainnet, rinkeby, harmony mainnet, etc ...) to which the user is connected and if he is connected.
Other than testnets, wouldn't the "Chain" field reflect this? which in the case where the user wants to payout with ONE, the relevant chain (harmony) will be shown on the "Chain" field
@nutrina What information do we need to make this decision? Lets have this conversation to finalzie this story and either make a call on what needs to change or clsoe as is. cc @willsputra
We only need to connect to a wallet for ETH chains, because we only take a fee for ETH chain. The connection to the wallet should happen in the last step (when bounty creation is confirmed). We take the fee in the last step.
We need to make sure this only shows a 10% fee for ETH tokens.. I cant verify this because there are no other tokens on other chains.
@nutrina - Can you validate that?
Otherwise the comment above looks good.
Moving this coment to the proper ticket.