passport icon indicating copy to clipboard operation
passport copied to clipboard

Update hash/id for on chain expiry notification generator

Open tim-schultz opened this issue 7 months ago • 0 comments

We need to update the on chain expiry notification generator so that notifications are generated each time an attestation expires instead of just the first time. Currently only the first time a chain's attestation expires a notificaiton will be generated due to the hashing function. Ideally we should add an expiration date so that the notification is tied to a specific expiration

Acceptance Criteria GIVEN the existing encoded_data structure for a provider on a blockchain, WHEN an expiration_date field is added to the structure, THEN the encoded_data should include the new expiration_date field, AND the id should update each time a provider's expiration date changes.

Referenced file https://github.com/gitcoinco/passport-scorer/blob/1c74a37dcc76f65e301139885408fc12b1987d7f/api/passport_admin/notification_generators/on_chain_expired.py#L15

tim-schultz avatar Jul 18 '24 15:07 tim-schultz