passport icon indicating copy to clipboard operation
passport copied to clipboard

Support for Multiple Wallets in the Staking App

Open nutrina opened this issue 10 months ago • 3 comments

User Story:

As an end-user, I want to connect to the staking app using Metamask, WalletConnect, Brave Wallet, and Coinbase Wallet, so that I can seamlessly stake and unstake GTC from multiple devices.

Acceptance Criteria

GIVEN I am an end-user, WHEN I navigate to the staking app at http://stake.passport.xyz/, THEN I should be presented with options to connect using:

  • Metamask (on both desktop and mobile devices)
  • WalletConnect (across all compatible devices)
  • Brave Wallet (on supported devices)
  • Coinbase Wallet (on supported devices)

Product & Design Links:

Tech Details:

  • Switch over to using Web3Modal, offering support for the four above specified wallet providers.

Open Questions:

Notes/Assumptions:

Ensure compatibility and testing across different platforms and devices for each wallet type.

nutrina avatar Apr 23 '24 08:04 nutrina

Taking a break from this task.

Right now, you can log in with walletconnect. But switching chains is only sometimes working. And there are some unhandled errors I haven't tracked down yet in (for example sometimes if you manually switch chains in the metamask mobile app connected with walletconnect).

Also, only a handful of testnets are supported by Rainbow wallet mobile, and OP sepolia isn't one of them.

Browser injected wallets seem to work fine still.

lucianHymer avatar Apr 29 '24 17:04 lucianHymer

From Erich, report of issue in main branch. Should check this in this branch:

get wagmi error toast and it pops up brave wallet when sign in with ethereum although i didn't select brave

lucianHymer avatar May 03 '24 13:05 lucianHymer

Team decided to move forward with Web3Modal

erichfi avatar May 07 '24 14:05 erichfi

Above PR needs to be merged before deployment, but the necessary update has already been done manually in the review env.

lucianHymer avatar May 14 '24 22:05 lucianHymer