grants-stack icon indicating copy to clipboard operation
grants-stack copied to clipboard

Redundant message if only one network

Open marsrobertson opened this issue 1 year ago • 1 comments

  1. Add grant on Optimism and Arbitrum
  2. Remove Optimism
  3. Checkout

EDIT / UPDATE: even simpler repro steps:

  1. Add grant on Arbitrum
  2. Checkout

(previously I was thinking that adding multiple networks sets multiple_networks = true but possible to repro with single network only)


This message is redundant / confusing:

Checkout all your carts across different networks or select the cart you wish to checkout now.

image

marsrobertson avatar Aug 16 '24 12:08 marsrobertson

can i be assign?

Ronexlemon avatar Oct 17 '24 06:10 Ronexlemon

@marsrobertson @MasterHW I'm not sure if this is the fix you are looking for? But does this address the issue? This is a cart with contributions on more than one network.

Screenshot 2024-10-29 115422

So it rightly displays the message on the modal at checkout.

Screenshot 2024-10-29 115524

The changes i've made:

Screenshot 2024-10-29 115615

Conditional rendering of the message on the modal such that it does not display if the networks being chaecked out in the cart are not more than 1. Even if there are multiple projects in the cart but are on the same network.

Screenshot 2024-10-29 115645

eben619 avatar Oct 29 '24 12:10 eben619