grants-stack icon indicating copy to clipboard operation
grants-stack copied to clipboard

fix: lowercase roundId on round page & application page

Open cristinalare opened this issue 1 year ago • 2 comments

Description

bug: if roundId isnt lowercase, round page & application page for allo v1 rounds doesnt load

View here: https://explorer.gitcoin.co/#/round/42161/0x5aA255d5CAe9B6cE0F2d9AEE209cB02349B83731/27 https://explorer.gitcoin.co/#/round/42161/0x5aA255d5CAe9B6cE0F2d9AEE209cB02349B83731

  • [x] convert round id to lowercase on round page & application page

Checklist

This PR:

  • [ ] Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • [ ] Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • [ ] Doesn't disable eslint rules.
  • [ ] Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • [ ] Doesn't contain commented out code.
  • [ ] If adding/updating a feature, it adds/updates its test script on Notion.

cristinalare avatar May 07 '24 16:05 cristinalare

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am

vercel[bot] avatar May 07 '24 16:05 vercel[bot]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/grant-explorer/src/features/round/ViewProjectDetails.tsx

Function Unhandled Issue
ViewProjectDetails TypeError: Cannot read properties of null (reading 'metadata') mapApplicationToProject(features/projects/hooks/u...
Event Count: 8 Affected Users: 11

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar May 07 '24 16:05 sentry[bot]