grants-stack icon indicating copy to clipboard operation
grants-stack copied to clipboard

Fix program filter

Open 0xKurt opened this issue 1 year ago • 2 comments

Context: https://discord.com/channels/562828676480237578/1234146304108531852

If the creator is the EOA, but the operator is the Safe and this will never return true. The newly introduced change filters the programs by Owner address

Fixes: #issue

Description

Checklist

This PR:

  • [ ] Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • [ ] Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • [ ] Doesn't disable eslint rules.
  • [ ] Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • [ ] Doesn't contain commented out code.
  • [ ] If adding/updating a feature, it adds/updates its test script on Notion.

0xKurt avatar Apr 28 '24 17:04 0xKurt

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:56am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:56am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:56am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:56am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:56am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:56am

vercel[bot] avatar Apr 28 '24 17:04 vercel[bot]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/round-manager/src/features/api/program.ts

Function Unhandled Issue
listPrograms Error: Unable to fetch programs listPrograms(feat...
Event Count: 6 Affected Users: 25

Did you find this useful? React with a 👍 or 👎

sentry[bot] avatar Apr 28 '24 17:04 sentry[bot]