grants-stack
grants-stack copied to clipboard
Add direct grants lite
DO NOT MERGE: We need to get the audit done first and deploy the new direct grants strategy to all networks
Flows Tested: http://localhost:3000/#/round/116
- :white_check_mark: Created DG on v2
- :white_check_mark: Edit DG on v2
- :white_check_mark: Apply on DG v2
- :white_check_mark: Approve for review on v2
- :white_check_mark: Reject on V2
- :white_check_mark: Approve on V2
- :white_check_mark: Payout on V2
- :white_check_mark: View stat for payout for v2
- :white_check_mark: Created DG on v1
- :white_check_mark: Edit Metadata DG on v1
- [x] Edit Timestamps DG on v1
- [x] Apply on DG v1
- [x] Approve for review on v1
- [x] Reject on V1
- [x] Approve on V1
- [x] Payout on V1
- [x] View stat for payout for v1
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| builder | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 13, 2024 8:06am |
| builder-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 13, 2024 8:06am |
| explorer | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 13, 2024 8:06am |
| explorer-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 13, 2024 8:06am |
| manager | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 13, 2024 8:06am |
| manager-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 13, 2024 8:06am |
🔍 Existing Issues For Review
Your pull request is modifying functions with the following pre-existing issues:
📄 File: packages/round-manager/src/features/program/ViewProgramPage.tsx
| Function | Unhandled Issue |
|---|---|
ViewProgram |
TypeError: nt is null program(context/program/Rea... Event Count: 1 Affected Users: 19 |
Did you find this useful? React with a 👍 or 👎
Results of my testing for V2 on Sepolia
- [x] successfully created a direct grants round
- [ ] round displays with incorrect info -- labeled as Quadratic Funding and does not reflect accurate start date (I think it should be 5/10/24)
- [ ] was not able to update direct grants round, console error attached
- [ ] round does not display correctly in explorer. should not show donate dates or matching pool amounts. https://explorer-staging-git-add-direct-grants-lite-grants-stack.vercel.app/#/round/11155111/133
- [ ] unable to apply to round because of invalid date issue https://builder-staging-git-add-direct-grants-lite-grants-stack.vercel.app/#/chains/11155111/rounds/133
I did validate that QF is working as expected in the branch with DG changes (on v2)
- [x] created a round
- [x] applied to a round
- [x] edited a round
- [x] accepted application
- [x] rejected application
Testing DG in Allo v1
- [ ] unable to deploy round with open end date
- [ ] unable to deploy round (end date is set) but not getting any errors, it just hangs? It's been over 5 min. Here's a link to my wallet in case it does wind up going through. https://sepolia.etherscan.io/address/0x58338E95caEf17861916Ef10daD5fAFE20421005
DG v1
- [x] created a round
- [x] edited a round
- [x] applied for a round
- [x] approved applications
- [ ] cannot pay out applications -- see screenshot and error attached. I have a blank screen that loads
DG v1
- [x] created a round
- [x] edited a round
- [x] applied for a round
- [x] approved applications
- [ ] cannot pay out applications -- see screenshot and error attached. I have a blank screen that loads
good catch! we need to prevent the user from removing required questions.
@melissa-neira the badges are already off since a while. maybe you want to create a ticket for it with a link/image of how they should look like?
the new strategy is currently not deployed to arbitrum, only sepolia
DG v1
- [x] created a round
- [x] edited a round
- [x] applied for a round
- [x] approved applications
- [ ] cannot pay out applications -- see screenshot and error attached. I have a blank screen that loads
i faced this one today: https://github.com/gitcoinco/grants-stack/issues/3424 which is kinda related to your problem with the removed token.
i have an idea on how to solve it and add the new feature with the token list. maybe we can talk about it next week really quick
DG v2
- [x] created round
- [x] edited round
- [x] applied to round
- [ ] I marked an application as in review from the application page in manager. The tx succeeded, but it was not reflected in the UI. Here's the tx: https://sepolia.etherscan.io/tx/0x66509ef35737d7d5973f81750f490347c82c08d33056cce741253524dda6720a
Screenshot of UI behind processing modal -- I tried again to approve from the Grant Applications page and after the page refresh the new status was reflected. Maybe we need to force a page refresh or something.
- [x] approved applications
- [ ] paid out applications -- not working because of same error as above with removing payout token field
- [x] view applications in explorer -- open end dates are not working as expected
small thing:
* the round status badges are behaving strangely
I was able to successfully deploy a round on sepolia, so yay!
The was done to accomidate the 'applications not started' badge, we can revisit how to render the badges in a nice consistent way.
@meglister The issue with the explorer timestamps appears because if you click the link you open the explorer in production and not staging.
Onq staging it's already fixed https://explorer-staging-git-add-direct-grants-lite-grants-stack.vercel.app/#/round/11155111/139
paid-out applications -- not working because of same error as above with removing payout token field
This is an existing bug and we will fix it in a follow up PR


* the round status badges are behaving strangely