grants-stack icon indicating copy to clipboard operation
grants-stack copied to clipboard

Add direct grants lite

Open 0xKurt opened this issue 1 year ago • 2 comments

DO NOT MERGE: We need to get the audit done first and deploy the new direct grants strategy to all networks

Flows Tested: http://localhost:3000/#/round/116

  • :white_check_mark: Created DG on v2
  • :white_check_mark: Edit DG on v2
  • :white_check_mark: Apply on DG v2
  • :white_check_mark: Approve for review on v2
  • :white_check_mark: Reject on V2
  • :white_check_mark: Approve on V2
  • :white_check_mark: Payout on V2
  • :white_check_mark: View stat for payout for v2

image

  • :white_check_mark: Created DG on v1
  • :white_check_mark: Edit Metadata DG on v1
  • [x] Edit Timestamps DG on v1
  • [x] Apply on DG v1
  • [x] Approve for review on v1
  • [x] Reject on V1
  • [x] Approve on V1
  • [x] Payout on V1
  • [x] View stat for payout for v1

0xKurt avatar Apr 22 '24 09:04 0xKurt

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am

vercel[bot] avatar Apr 22 '24 09:04 vercel[bot]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/round-manager/src/features/program/ViewProgramPage.tsx

Function Unhandled Issue
ViewProgram TypeError: nt is null program(context/program/Rea...
Event Count: 1 Affected Users: 19

Did you find this useful? React with a 👍 or 👎

sentry-io[bot] avatar Apr 22 '24 09:04 sentry-io[bot]

Results of my testing for V2 on Sepolia

  • [x] successfully created a direct grants round
  • [ ] round displays with incorrect info -- labeled as Quadratic Funding and does not reflect accurate start date (I think it should be 5/10/24) Screenshot 2024-05-08 at 9 36 12 PM
  • [ ] was not able to update direct grants round, console error attached Screenshot 2024-05-08 at 9 38 27 PM
  • [ ] round does not display correctly in explorer. should not show donate dates or matching pool amounts. https://explorer-staging-git-add-direct-grants-lite-grants-stack.vercel.app/#/round/11155111/133 Screenshot 2024-05-08 at 9 39 47 PM
  • [ ] unable to apply to round because of invalid date issue https://builder-staging-git-add-direct-grants-lite-grants-stack.vercel.app/#/chains/11155111/rounds/133 Screenshot 2024-05-08 at 9 41 53 PM

meglister avatar May 09 '24 01:05 meglister

I did validate that QF is working as expected in the branch with DG changes (on v2)

  • [x] created a round
  • [x] applied to a round
  • [x] edited a round
  • [x] accepted application
  • [x] rejected application

meglister avatar May 09 '24 01:05 meglister

Testing DG in Allo v1

  • [ ] unable to deploy round with open end date Screenshot 2024-05-08 at 10 07 09 PM
  • [ ] unable to deploy round (end date is set) but not getting any errors, it just hangs? It's been over 5 min. Here's a link to my wallet in case it does wind up going through. https://sepolia.etherscan.io/address/0x58338E95caEf17861916Ef10daD5fAFE20421005 Screenshot 2024-05-08 at 10 20 18 PM

meglister avatar May 09 '24 02:05 meglister

DG v1

  • [x] created a round
  • [x] edited a round
  • [x] applied for a round
  • [x] approved applications
  • [ ] cannot pay out applications -- see screenshot and error attached. I have a blank screen that loads Screenshot 2024-05-09 at 2 01 36 PM

meglister avatar May 09 '24 18:05 meglister

DG v1

  • [x] created a round
  • [x] edited a round
  • [x] applied for a round
  • [x] approved applications
  • [ ] cannot pay out applications -- see screenshot and error attached. I have a blank screen that loads Screenshot 2024-05-09 at 2 01 36 PM

good catch! we need to prevent the user from removing required questions.

codenamejason avatar May 09 '24 18:05 codenamejason

@melissa-neira the badges are already off since a while. maybe you want to create a ticket for it with a link/image of how they should look like?

the new strategy is currently not deployed to arbitrum, only sepolia

0xKurt avatar May 09 '24 18:05 0xKurt

DG v1

  • [x] created a round
  • [x] edited a round
  • [x] applied for a round
  • [x] approved applications
  • [ ] cannot pay out applications -- see screenshot and error attached. I have a blank screen that loads Screenshot 2024-05-09 at 2 01 36 PM

i faced this one today: https://github.com/gitcoinco/grants-stack/issues/3424 which is kinda related to your problem with the removed token.

i have an idea on how to solve it and add the new feature with the token list. maybe we can talk about it next week really quick

0xKurt avatar May 09 '24 18:05 0xKurt

DG v2

  • [x] created round
  • [x] edited round
  • [x] applied to round
  • [ ] I marked an application as in review from the application page in manager. The tx succeeded, but it was not reflected in the UI. Here's the tx: https://sepolia.etherscan.io/tx/0x66509ef35737d7d5973f81750f490347c82c08d33056cce741253524dda6720a Screenshot of UI behind processing modal -- I tried again to approve from the Grant Applications page and after the page refresh the new status was reflected. Maybe we need to force a page refresh or something. Screenshot 2024-05-09 at 2 51 32 PM
  • [x] approved applications
  • [ ] paid out applications -- not working because of same error as above with removing payout token field Screenshot 2024-05-09 at 2 53 58 PM
  • [x] view applications in explorer -- open end dates are not working as expected Screenshot 2024-05-09 at 2 48 55 PM

meglister avatar May 09 '24 18:05 meglister

small thing:

Screenshot 2024-05-09 at 20 26 39 * the round status badges are behaving strangely

I was able to successfully deploy a round on sepolia, so yay!

The was done to accomidate the 'applications not started' badge, we can revisit how to render the badges in a nice consistent way.

codenamejason avatar May 09 '24 20:05 codenamejason

@meglister The issue with the explorer timestamps appears because if you click the link you open the explorer in production and not staging.

Onq staging it's already fixed https://explorer-staging-git-add-direct-grants-lite-grants-stack.vercel.app/#/round/11155111/139

paid-out applications -- not working because of same error as above with removing payout token field

This is an existing bug and we will fix it in a follow up PR

0xKurt avatar May 10 '24 08:05 0xKurt