grant-hub icon indicating copy to clipboard operation
grant-hub copied to clipboard

application: Project Details dropdown is missing toggle, missing headers for logo/banner, and the font sizing is too big

Open michellema1208 opened this issue 2 years ago • 5 comments

From @michellema1208: Project Details dropdown is missing toggle, missing headers for logo/banner, and the font sizing is too big (should be 12 for the toggle, 14 for the inputs)

The Project Details dropdown should look like this (Figma):

Screen Shot 2022-09-21 at 7 25 12 PM

michellema1208 avatar Sep 21 '22 23:09 michellema1208

⚠️ Status Update: Staying in "PM/UX review", awaiting Design review

@willsputra when you get the chance, can you test this ticket? Basically go to application > select a project > see project details dropdown

I think the functionality is all there (and looks much better than it did before), but I'm noticing the font/sizing is a bit off, there are some extra dividers above and below "Project Details", it looks like the banner image is slightly off left-alignment, etc. I'd love to hear your thoughts on if this is worth adjusting, or if we should keep it as is / no significant difference in design vs. implementation.

Would love your Design/UX review here, before we sign off on this ticket to be deployed.

cc: @DanieleSalatti

michellema1208 avatar Sep 23 '22 19:09 michellema1208

@michellema1208 cc @DanieleSalatti

These aren't blockers or super critical but what I'd love to change:

  • Change "Project Details" to "View your Project Details"
  • Change "View your Project Details" font to Libre Franklin
  • More spacing between each form inputs image

Stretch goals (we don't have to change this if we don't have time):

  • Remove the extra divider lines above and below "Project Details"
  • Make sure the Project Details title and form inputs are aligned to the left (aligned to the rest of the form)

willsputra avatar Sep 25 '22 11:09 willsputra

  • [X] Change "Project Details" to "View your Project Details"
  • [x] Change "View your Project Details" font to Libre Franklin
  • [X] More spacing between each form inputs image
  • [X] Remove the extra divider lines above and below "Project Details"
  • [X] Make sure the Project Details title and form inputs are aligned to the left (aligned to the rest of the form)

Working on changing the font next.

DanieleSalatti avatar Sep 26 '22 12:09 DanieleSalatti

hey @DanieleSalatti - I'm looking at this on staging, and it looks like a few things are still missing - like it still says "Project Details" instead of "View your project details", it doesn't look like the extra divider lines above and below "Project Details" have not been removed, etc. Double checking that this PR has been merged?

michellema1208 avatar Sep 28 '22 00:09 michellema1208

✅ Status Update: Moving to Ready for Deployment

@DanieleSalatti - Will and I have tested the above changes, and this looks good to us. There is one minor spacing issue on the Project Details dropdown, but we will track that in a separate ticket for style/feature enhancements.

michellema1208 avatar Sep 30 '22 15:09 michellema1208