grant-hub icon indicating copy to clipboard operation
grant-hub copied to clipboard

Add application error states

Open michellema1208 opened this issue 2 years ago • 4 comments

Tasks

  • [ ] Add error states to application (see below) - should name any required fields in the error box that have not filled out
error

michellema1208 avatar Sep 16 '22 14:09 michellema1208

⚠️ Status Update: Moving back to "In Progress"

hey @codenamejason - I just tested this change, and I see that it's working for most of the form fields, with a few inconsistencies. I found that:

PRIORITY

  • The answers validate after you hit Preview, when the answers should be valid before the Preview button is enabled (this is what we had previously but perhaps it got overridden...)
  • When all of my answers are valid, I hit Preview, and the Submit button is now disabled and I cannot apply

STYLE UPDATES

  • The copy for when someone skips the "Is your payout wallet a Gnosis Safe or multi-sig" question says "Is this project a safe is required" -> since we're checking the wallet address not the project, the copy should read "Is your payout wallet a Gnosis Safe or multi-sig is required"
  • The style of the error box is inconsistent with Will's original designs: missing the "x" symbol, the body of the text should be Black, it looks like the font type/size are different as well (Feel free to use Figma for reference, or ping @willsputra for more info)
  • The question should say "Payout Wallet Address" not "Recipient Address" (to be consistent with the multisig question)

Currently in staging: Image

Will's original designs: Image

michellema1208 avatar Sep 23 '22 20:09 michellema1208

@michellema1208 the label for the wallet address comes from round-manager and if round-manager doesn't send one we provide the value label={input.question ?? "Payout Wallet Address"}. Should we hardcode the "Payout Wallet Address"?

codenamejason avatar Sep 27 '22 21:09 codenamejason

@codenamejason in short, yes! Since we (Grant Hub) are adding the Payout Wallet Address question to the application form every time, we should also be the ones setting the label to "Payout Wallet Address" - we shouldn't be pulling that from the round metadata from round-manager.

I think round-manager having a label for Payout Wallet Address may be something that was never cleaned up after we decided that Grant Hub would always load the Payout Wallet Address question on every application form (for context).

michellema1208 avatar Sep 28 '22 00:09 michellema1208

✅ Status: Moving to "Ready for Deployment"

@codenamejason I tested this, and it has addressed the functional errors I shared above. There are some style enhancements I'd like to make, but I will track them and prioritize them in a separate ticket.

michellema1208 avatar Sep 28 '22 01:09 michellema1208