grant-hub icon indicating copy to clipboard operation
grant-hub copied to clipboard

general: error page

Open michellema1208 opened this issue 2 years ago • 5 comments

TBD - may need designs

michellema1208 avatar Sep 09 '22 15:09 michellema1208

Uploading image here for reference

Image

DanieleSalatti avatar Sep 20 '22 17:09 DanieleSalatti

⚠️ Status Update: Moving back to "In Progress"

hey @DanieleSalatti ! I just tested this, and it looks like what we have currently in the app is pretty different from Will's original designs (Figma).

Current state:

Image

Original Designs: Image

To help itemize some changes:

  • The copy is missing (see designs above)
  • The "go back home" button is styled different (see designs above)
  • The 404 image should be formatted in a way that is not overlapping - it should fit under the copy and above the watermark
  • The page is also missing the "Built by the Gitcoin Community" watermark at the bottom

This is one me - I forgot to update the original ticket with the screenshot of the designs when you picked up the ticket, but I'd also love for all of us (Product & Eng) to make a habit of consistently referring to the designs that Will has put together. We can jam more on this process in our upcoming retro!

michellema1208 avatar Sep 23 '22 18:09 michellema1208

@willsputra can you take a look at this change when you're back online?

Two things that jump out at me: the "Discord" seems to be bolded and a different font size than what you had in the original designs, and I think the "Go back home" button needs to have some spacing from the copy + "home" should be lower-case. Can you review this and confirm / share if there are any other design enhances that need to be made?

This is what I'm seeing: Image

Tested using this URL: https://staging.granthub.gitcoin.co/#/abcdefg

michellema1208 avatar Sep 28 '22 00:09 michellema1208

@michellema1208 yeah I'm also seeing the same thing! image

agree with the changes:

  • [ ] more spacing between copy and button
  • [ ] lower case "Home"
  • [ ] make sure the font styles are Libre Franklin and the weights are consistent

willsputra avatar Sep 28 '22 08:09 willsputra

✅ Status Update: Moving to "Ready for Deployment"

@DanieleSalatti per what we chatted about in standup, we will be moving this forward and track the style/feature enhancements in a separate ticket.

michellema1208 avatar Sep 30 '22 15:09 michellema1208