browser-extension
browser-extension copied to clipboard
gitcoinco
Firefox
Why?
We want to be able to add the gitcoin extension to firefox.
What Changed?
- Used Web Extensions API to make calls universal.
- Updated jQuery
- Fixed innerHTML issue
References
#1
not sure why, but this version of the extension seems to not recognize the existence of metamask => http://bits.owocki.com/3D3v3v3d0v29/Screen%20Shot%202018-02-26%20at%204.52.33%20PM.png
do i need to worry about these warning messages when loading the temporary add on to firefox?
Reading manifest: Error processing background.persistent: Event pages are not currently supported. This will run as a persistent background page.
Reading manifest: Error processing storage: An unexpected property was found in the WebExtension manifest.
not sure why, but this version of the extension seems to not recognize the existence of metamask => http://bits.owocki.com/3D3v3v3d0v29/Screen%20Shot%202018-02-26%20at%204.52.33%20PM.png
this seems to happen in both chrome / firefox
@gasolin @owocki So issue this issue closed? I saw all the work gasolin did. Great job!
@KennethAshley no some API is not fully migrated yet and the previous branch is not test covered. You can take the bounty by cherry-picking those PR and merge to the master(I should do that but currently occupied), and fix the rest of issues.
for context, i reverted a lot of that code in the branch because of regressions. here are my notes from when i did so https://github.com/gitcoinco/chrome_ext/pull/44
@owocki I actually think the use of the older version of jQuery is blocking us.
shoot..
maybe we could just reference the jquery veresion from the CDN instead of trying to build / package it internally? or maybe we need to update to the latest jqeury