gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard
verified publisher icon gitbutlerapp

GitButler doesn't recognize allowed GitHub PR merge methods

Open jackTabsCode opened this issue 7 months ago • 1 comments

Version

0.14.19

Operating System

macOS

Distribution Method

dmg (Mac OS - Apple Silicon)

Describe the issue

When trying to merge a PR in GitButler with a method that is not allowed in your GitHub repository's settings, GitButler will do nothing and output no error.

How to reproduce (Optional)

  1. Create a repository and turn off "Allow rebase merging" and "Allow merge commits"
  2. Make some changes and create a PR with GitButler
  3. Attempt to merge the pull request using a default option
  4. Nothing happens
  5. Switch the method to squash, squash and merge
  6. It works

Expected behavior (Optional)

GitButler should grey out these options like on the web PR view.

Relevant log output (Optional)

jackTabsCode avatar May 05 '25 17:05 jackTabsCode

Thanks a lot for reporting!

Maybe as a start we could look into why failures to interact with forges don't propagate so they are user-observable. Maybe there even is a general way of tackling this, but @estib-vega certainly has ideas as well.

Byron avatar May 06 '25 06:05 Byron