gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard

Branch search: failing to find branch by exact name

Open ivan-kiselev opened this issue 11 months ago • 10 comments

Version

0.14.6

Operating System

macOS

Distribution Method

dmg (Mac OS - Apple Silicon)

Describe the issue

I have a monorepo with fairly large amount of branches (~1700).

I am trying to find a branch in GitButler UI using search bar in "All" column by copying branch from GitHub UI using the convenience copy button, and just simply paste it to the GitButler UI.

Nothing shows up.

I can locate the branch manually by just scrolling down and looking for it. In the same time, some other branches are perfectly searchable.

When I locate the branch manually and select it, it shows some inner unique ID instead of human-readable name. If I use this unique ID - search works.

Image

Branch exists in remote. PR associated with the branch was closed without deleting the branch.

It seems that there's some mix up on what field of branch object to display and use for search in UI?

How to reproduce (Optional)

No response

Expected behavior (Optional)

Users should not see unique identifiers of branches, that should be internal detail hidden from the users. Branches should be searchable by human-readable names, whether local or remote.

Relevant log output (Optional)


ivan-kiselev avatar Jan 22 '25 09:01 ivan-kiselev

Thanks a lot for reporting!

This is indeed an implementation detail leaking into user-visible branches and as far as I could find out, there is isn't a good solution for it yet.

I will also try to keep this in mind and hope to keep you posted. CC @krlvi , keywords: branch stack unique-id surprise surprising

Byron avatar Jan 22 '25 14:01 Byron

It's not a major blocker, obviously, but it takes away quite some convenience of the tool, especially for big and active repos. I also have repos with just few branches and little activity, so it's not a big deal there, but when one has dozens of branches created daily, that becomes really counter-productive.

ivan-kiselev avatar Jan 23 '25 11:01 ivan-kiselev

This is really stupid and improving it shouldn't be that hard, let me take a stab at this

Caleb-T-Owens avatar Jan 23 '25 23:01 Caleb-T-Owens

@Caleb-T-Owens any hints on when is this expected to be released? This problem is probably one that solely brings me out of GitButler workflow back to regular git cli as I literally can't find branches among 1.5k of them 😅

ivan-kiselev avatar Feb 04 '25 10:02 ivan-kiselev

@Caleb-T-Owens any hints on when is this expected to be released? This problem is probably one that solely brings me out of GitButler workflow back to regular git cli as I literally can't find branches among 1.5k of them 😅

@ivan-kiselev i was just making the release notes for 0.14.7 which includes this fix. Should be out in 15 minutes from now :)

krlvi avatar Feb 05 '25 13:02 krlvi

YEAAAAH DAWG!

Nothing like evening notification pop about new version that fixes bug you are hitting!

ivan-kiselev avatar Feb 05 '25 16:02 ivan-kiselev

@ivan-kiselev Sorry for taking a while with the release! If you have any more problems with searching, please let us know!

Caleb-T-Owens avatar Feb 05 '25 17:02 Caleb-T-Owens

@Caleb-T-Owens @krlvi hey folks!

Still seeing this on 0.14.8 for local branches:

Image

I don't have permissions to re-open the issue but I think it should be.

ivan-kiselev avatar Feb 26 '25 08:02 ivan-kiselev

Another example how it's broken:

Image Image

ivan-kiselev avatar Apr 10 '25 13:04 ivan-kiselev

Sorry for that :/!

For a moment I was intrigued by that new "Code with CoPilot" button on the right sidebar and thought that something silly like this should pop out to an LLM pretty well.

But have to move on for now as a lot of other issues piled up.

Byron avatar Apr 12 '25 12:04 Byron