Instead of "Something went wrong..." display ssh error

[koppor]

Version

0.13.0

Operating System

Windows

Distribution Method

msi (Windows)

Describe the issue

When there are issues with git after quitting a conflict edit "Something went wrong..." is displayed.

How to reproduce

1. I used GitButler
2. GitButler asked for resolving merge conflicts
3. I did not
4. I closed git butler
5. I closed my SSH key server
6. I restarted GitButler.
7. GitButler said, I was in editing mode
8. I pressed "Cancel"
9. GitButler displayS: "Something went wrong..."

I checked the logs:

It seems that something is wrong with SSH

Expected behavior

GitButler should output issues with git.

Relevant log output

[Byron]

Thanks a lot for reporting!

A lot happened in the steps to reproduce, and some of that may very well be the reason for the failure. However, the only idea I have relates to the SSH and keyserver parts. Now I wonder if SSH wanted to obtain a password, but couldn't do it as it needed a terminal? But then again it's unclear how it did ever work if restarting the keyserver is now a problem.

On MacOS with authentication and missing popups or environment variables can typically be resolved by launching GitButler from a terminal, but I don't know if that makes any difference on Windows.

[koppor]

A lot happened in the steps to reproduce,

😇

and some of that may very well be the reason for the failure. However, the only idea I have relates to the SSH and keyserver parts. Now I wonder if SSH wanted to obtain a password, but couldn't do it as it needed a terminal?

It could not do it, because there was no server available. (The terminal itself worked IMHO)

But then again it's unclear how it did ever work if restarting the keyserver is now a problem.

I was not clear: It is super simple: The server did not run. (Expanded: If users use KeeAgent, the database for KeePass needs to run. And I did not run KeePass 😅)

On MacOS with authentication and missing popups or environment variables can typically be resolved by launching GitButler from a terminal, but I don't know if that makes any difference on Windows.

Similar things here. (Long text on that at https://github.com/javakeyring/java-keyring?tab=readme-ov-file#security-concerns).

[Byron]

Thanks for the clarification :)! I think the real issue here is that while in this particular state, the UI ends up in Something went wrong mode, which is somewhat equivalent to a hard crash. It can be provoked by making Git fetches fail.

Ideally, the UI will gracefully handle this.

[koppor]

Thanks for the clarification :)! I think the real issue here is that while in this particular state, the UI ends up in Something went wrong mode, which is somewhat equivalent to a hard crash. It can be provoked by making Git fetches fail.

Ideally, the UI will gracefully handle this.

Yeah - and it does at other places; it least shows up the error as notification.