gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard

feat: svelte 5 migration

Open ndom91 opened this issue 1 year ago • 1 comments

☕️ Reasoning

  • Svelte 5 migrator was released
  • I let it run over apps/desktop/src/*

Notes

  • There seem to be some issues with the types in the Storybook stories
  • Double check what the run() polyfill is that was auto-inserted in a few places

🧢 Changes

  • Applied to the apps/desktop/src/* directory
    • There were a decent amount of eslint issues I had to fix, but the dev app seems to at least start up normally. I will double check everything this week 🤞
  • Also bumped the svelte-related dependencies in pnpm-workspace.yaml to their latest versions

ndom91 avatar Sep 29 '24 16:09 ndom91

So how many bits is “a few”? Where are they located (e.g. code or data)? What are the differences?

cuavas avatar Oct 06 '24 15:10 cuavas

More details can be found at its no-intro page: https://datomatic.no-intro.org/index.php?page=show_record&s=32&n=0437

ICEknigh7 avatar Oct 06 '24 18:10 ICEknigh7

So how many bits is “a few”? Where are they located (e.g. code or data)? What are the differences?

I listed the locations of the two bytes on no-intro, but here's a diff showing the difference, highlighted in red. What Mame has recorded on top, my dump on the bottom. Again, confirmed from 3 carts and a desoldered chip (and matching other dumps). I suppose it's one byte and one bit to be technical - for a total of 9 bits. On a binary level, it is 11101111 00000000 vs 11111111 11111111. image

Happy to answer any other questions! My pics are on my no-intro dumps!

PsychoFox11 avatar Oct 07 '24 10:10 PsychoFox11

@PsychoFox11 This was recently committed to the official MAME source files but the data added was not sent in for verification purposes. Please use the email address mentioned at the link below to send this data or a link to it so that this PR can be completed. Thank you for your contribution!

https://wiki.mamedev.org/index.php/Submitting_Source_Code#Submitting_ROM_or_disk_dumps

Tafoid avatar Nov 15 '24 14:11 Tafoid

Information has been uploaded.

Robbbert avatar Nov 15 '24 15:11 Robbbert

I just emailed the info as requested but wasn't sure if I needed to based on the last comment (was it uploaded by someone else)? Worst case you got it twice I guess? First time contributing!

PsychoFox11 avatar Nov 18 '24 01:11 PsychoFox11