Bug: checkboxes misbehave, a lot.

[TheYarin]

Version

0.12.24

Operating System

Windows

Distribution Method

msi (Windows)

Describe the issue

A few checkboxes issues:

1. They don't accurately represent the state of their children:
   1. deselecting a hunk from a fully selected file changes the checkmark to an empty box instead of a "partial" sign
   2. manually selecting all of the hunks in a file does not change its checkbox to checkmark. But the "all files" checkbox is checked? awkward
2. There's an unintuitive grayed-out checkmark sign, no idea what it's supposed to represent
3. when any files are changed, all the files are auto selected, which is REALLY annoying when I'm in the middle of organizing my commits and staging specific hunks
4. If I manually uncheck a file and then click the "all files" checkbox, it no longer checks the file I unchecked. But the "all files" checkbox is still marked as "checked", despite some files not being checked.

How to reproduce

No response

Expected behavior

We can all imagine the intuitive behavior of a checkbox tree, right?

Relevant log output

No response

[Byron]

Thanks a lot for reporting! It sounds like the logic behind the checkboxes can indeed be improved, and I appreciate to have these bundled in a single issue.

Maybe @estib-vega finds this topic interesting as well.

[TheYarin]

Amazing @estib-vega, I'll test the new version and report back

[TheYarin]

I'm glad to report the commit-composing experience is significantly less unpredictable thanks to the checkboxes behaviours update.

However, I still see this checkmark from time to time and I don't know what to make of it:

[estib-vega]

However, I still see this checkmark from time to time and I don't know what to make of it:

@TheYarin hey there, happy to hear that!

If you're referring to the little gray checkmark that would be its hover-state look.

[TheYarin]

@estib-vega If so, why does it stay visible even when I'm not hovering over this checkbox? 🤔

to reproduce, simply uncheck a checked checkbox

[estib-vega]

@estib-vega If so, why does it stay visible even when I'm not hovering over this checkbox? 🤔

to reproduce, simply uncheck a checked checkbox

@TheYarin I believe that would be the focus state. Currently focus and hover state are the same style-wise for the checkboxes

[TheYarin]

@estib-vega is there a chance to change this definition? It's pretty confusing 😅

[PavelLaptev]

@estib-vega since this appears to be purely a design issue, I’ve reassigned it to myself.