gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard

Test push can trigger CI jobs, should user be warned? Or test pushing notes instead?

Open nbelakovski opened this issue 1 year ago • 2 comments

Version

0.12.20

Operating System

Mac OS X

Distribution Method

dmg (Apple Silicon)

Describe the issue

A couple hours after I did the test push I noticed there was a failed CI job in my repo. It turned out to have been triggered by the test push, but it failed because git butler deleted the branch so quickly that by the time the CI job got around to downloading it, it was gone.

There was no harm done, but some people might have deployments or notices or other things triggered by CI. I don't know if there's any other way to test push without having this problem, but maybe a warning for users that the test push might trigger CI jobs would be useful.

How to reproduce

When first setting up gitbutler do a test push

Expected behavior

No side effects

Relevant log output

N/A

nbelakovski avatar Aug 26 '24 21:08 nbelakovski

Perhaps you could test pushing a note instead. I might have suggested tag but people do use tags quite a lot and you can never account for all weird logic. Notes are pretty rarely used and if someone is triggering a deployment or something based on notes instead of something more reasonable like commits or tags I say that's on them :D

nbelakovski avatar Aug 26 '24 21:08 nbelakovski

Thanks a lot for reporting and for the suggestion!

I agree that ideally, one can choose a ref that is unlikely to trigger additional side-effects.

Byron avatar Aug 27 '24 04:08 Byron