gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard

Cannot delete virtual branch

Open DiogoM14 opened this issue 1 year ago • 3 comments

Version

0.12.16

Operating System

Mac OS X

Distribution Method

dmg (Apple Silicon)

Describe the issue

If you apply a virtual branch and then try to delete it, a "Delete successful" message appears, but the branch is only unapplied, not deleted.

How to reproduce

Unapply a branch -> delete branch

Expected behavior

The virtual branch should be deleted

Relevant log output

No response

DiogoM14 avatar Aug 02 '24 09:08 DiogoM14

Hey! Thanks for reporting! I think there is some UX ambiguity here but also potentially a bug, and I have a guess for what is going on here.

The app allows ppl to create a virtual branch from any local or remote branch (so that one can review/ test code etc). If a virtual branch lane was created in this way, then deleting it will not delete the branch that existed before - this is by design because we wouldn't want the app to accidentally interfere with other branches.

However, recently we changed the way unapplying of a virtual branch works - it now creates a regular git branch. It seems like now, if one has previously unapplied a virtual branch, then deleting it will leave that local branch untouched. We are working on a redesign of the branch listing on the left, and as soon as we have that shipped we will take a second look at how we approach deletion

krlvi avatar Aug 02 '24 09:08 krlvi

Would this be an ability to delete local or remote branches similarly? @krlvi

LovesAsuna avatar Aug 12 '24 11:08 LovesAsuna

Would this be an ability to delete local or remote branches similarly?

Hey @LovesAsuna - you currently can delete local branches via the GitButler UI: image

However, deleting remote branches is currently not able via the GitButler UI (and I think it is not a goal to make that possible). If a remote branch gets deleted, GitButler automatically removes it from the UI (if you have no local version of it).

H1ghBre4k3r avatar Aug 27 '24 13:08 H1ghBre4k3r