gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard

Incorrect report about running checks

Open Fryuni opened this issue 1 year ago • 2 comments

I have tests still running, but the ones that have been completed have all passed. Until the last check completes or one of them fails, it shows both "checks passed" (implying that everything is fine) and a warning stating that checks failed.

image

Fryuni avatar May 04 '24 00:05 Fryuni

Intel Mac, latest version

Nothing blocking, it is only while the tests are still running. Once the tests are completed, be it failing or succeeding, it reports correctly.

Fryuni avatar May 04 '24 03:05 Fryuni

I'm getting this warning on a repo has required reviewers on a PR that 1. has all tests passing but 2. was not yet approved by a reviewer.

After the review, the warning went away.

So maybe the warnings should be specific to each state or more general that merging is blocked?

kochalex avatar May 24 '24 17:05 kochalex

So maybe the warnings should be specific to each state or more general that merging is blocked?

Agreed. I assume the GH API distinguishes between failing checks and pending reviews, but the message in GitButler does not. If GH doesn't distinguish, then this issue can't be addressed.

khalil-omer avatar Jul 07 '24 02:07 khalil-omer