gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard
verified publisher icon gitbutlerapp

Fix advanced commits

Open schacon opened this issue 1 year ago • 1 comments

@krlvi feature flagged the advanced commits, but in a way that it's still only the head that works if the flag is on. This should fix it.

schacon avatar May 03 '24 13:05 schacon

Hey @schacon!

I'm not sure that this is quite right as this means that the field to edit the commit message is available on ALL commits (including those in the Trunk page and branch views).

I made a commit to set isUndoable based on whether the commit is an instance of Commit (opposed to RemoteCommit) and whether the branch is applied which correctly only shows the advanced commit operations on commits that we can (and want to) perform them on.

https://github.com/gitbutlerapp/gitbutler/pull/3682/commits/fe30db9760e0a8f6346a08a6b76349b889e3cf4d

Caleb-T-Owens avatar May 03 '24 19:05 Caleb-T-Owens

@Caleb-T-Owens nice. Did you merge that in?

schacon avatar May 04 '24 06:05 schacon

Closed in favor of #3682

schacon avatar May 04 '24 07:05 schacon

@Caleb-T-Owens nice. Did you merge that in?

@schacon It's part of #3683. I was hoping to have a quick OK from pavel before I merged it in just to make sure it wasn't a total modal butchery or something like that 😆

Caleb-T-Owens avatar May 04 '24 07:05 Caleb-T-Owens