gitbutler icon indicating copy to clipboard operation
gitbutler copied to clipboard

Add summary and description fields. Show tooltip for long summary messages

Open PavelLaptev opened this issue 11 months ago • 5 comments

Based on https://github.com/gitbutlerapp/gitbutler/pull/2789

Changes:

  • Added two fields for summary and description
  • If summary is too long, show tooltip icon

https://github.com/gitbutlerapp/gitbutler/assets/18498712/402a6dcb-9051-49b8-9882-d6f11056cdd3

PavelLaptev avatar Mar 13 '24 01:03 PavelLaptev

Sorry for leaving so many comments here, but I'd love for you to do one more thing, in the spirit of constantly improving the quality of this code base. Could you rewrite the commit() function to an async function that uses await rather than .then(...)? I know you didn't write that function, but it would be nice thing to do. :)

mtsgrd avatar Mar 13 '24 10:03 mtsgrd

All good, my aim is to make it right 🙂

PavelLaptev avatar Mar 13 '24 10:03 PavelLaptev

@mtsgrd thank you! I'll QA it again and then merge

PavelLaptev avatar Mar 14 '24 13:03 PavelLaptev

Seems like a race condition here - textarea takes the height of the previous condition. I'll check if I can fix it 🙂

https://github.com/gitbutlerapp/gitbutler/assets/18498712/a5e5cf02-fa9a-4bc7-b863-f474f70e28b4

PavelLaptev avatar Mar 14 '24 21:03 PavelLaptev