Make `but review publish` take a CliId instead of requiring `-b branch`

[Copilot]

Make but review publish take a CliId instead of requiring -b branch

Implementation Summary: This PR implements the requested feature from issue #11027 to make but review publish accept a CliId as a positional argument, consistent with how the rub command works.

Changes Made:

1. Modified command structure (forge/review.rs):

   • Changed branch field from a flag (-b/--branch) to a positional optional argument
   • Updated help text to indicate it accepts "Branch name or CliId"

2. Added CliId resolution (forge/review.rs):

   • Created resolve_branch_name() helper function with comprehensive documentation that:
     • Uses CliId::from_str() to resolve branch input (handles both exact names and partial matches)
     • Handles ambiguous matches with clear error messages
     • Ensures the resolved CliId is actually a branch (not a commit, file, etc.)
     • Provides helpful error messages consistent with the rub command
     • Avoids unnecessary cloning by using owned value extraction

3. Updated publish logic (forge/review.rs):

   • Modified publish_reviews() to call resolve_branch_name() when a branch is specified
   • Maintains backward compatibility - still accepts full branch names

Code Review Feedback Addressed:

• ✅ Simplified error message to avoid redundancy
• ✅ Added clarifying comment explaining that CliId::from_str handles both exact branch names and CliId matches
• ✅ Added comprehensive documentation for resolve_branch_name function
• ✅ Optimized branch name extraction to avoid unnecessary cloning

New Behavior:

• ✅ but review publish - publishes reviews for all active branches (unchanged)
• ✅ but review publish branch-name - publishes review for the specified branch (new positional argument)
• ✅ but review publish <CliId> - publishes review for the branch matching the CliId (new feature)
• ✅ Supports partial branch name matching (consistent with rub command)
• ✅ Clear error messages for ambiguous matches or invalid inputs

Error Handling: The implementation includes comprehensive error handling:

• Empty matches: "Branch '...' not found..."
• Ambiguous matches: "Branch identifier '...' is ambiguous. Matches: ..."
• Wrong entity type: "Expected a branch, but '...' resolved to ..."

All error messages are consistent with the existing rub command patterns.

Testing:

• Code formatted with cargo fmt
• Changes follow existing patterns in the codebase
• Error handling is consistent with similar commands
• All code review feedback addressed
• Function properly documented with rustdoc

Original prompt

https://github.com/gitbutlerapp/gitbutler/issues/11027

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
gitbutler-web	Ignored	Preview		Nov 6, 2025 1:15pm

[Byron]

@copilot continue

[Byron]

@copilot continue

[Copilot]

@copilot continue

The implementation is complete and ready for review. The PR description has been updated to remove the WIP tag.

Summary of changes:

• Changed but review publish -b branch to but review publish branch (positional argument)
• Added CliId resolution support, allowing users to use branch names, partial matches, or CliId hashes
• All code is formatted and documented
• Error handling matches the rub command patterns

The implementation is ready for testing and merging.

[Byron]

Closing as the moment has passed 😅.