Unable to create branch sometimes

[swelborn]

Version

0.16.10

Operating System

macOS

Distribution Method

dmg (Mac OS - Apple Silicon)

Describe the issue

https://github.com/user-attachments/assets/7e552842-3e1c-445c-b831-a603b35d909a

I notice this issue when I am trying to create a new branch. I am not sure what is the reproducer here. The create branch button is greyed. It seems like sometimes the window will pop up with the create branch button highlighted, but as soon as I remove all of the text from that box to change the default name, it goes away and I cannot get it back. Clicking around the UI seems to reset something.

When I went back to capture the log, it appeared that there was a flood of logs about rate limiting, but something in the UI said Octokat had rate limited me. Regrettably I could not capture the log as it froze the app.

This could perhaps have been the real issue and the video above was a red herring.

Could be some component in an infinite re-render loop.

If it happens again I will update the issue.

How to reproduce (Optional)

No response

Expected behavior (Optional)

No response

Relevant log output (Optional)

No response

[Byron]

Thanks a lot for reporting!

It seems like the video is broken, unfortunately, but from the text it seems the strange behaviour might be related to rare limiting warnings related to the GitHub API. The issue also doesn't reproduce for me, so maybe more has to happen.

There have been rate-limit fixes recently, and I wonder if this issue would go away if you were to use a Nightly build.

[swelborn]

thanks for getting back. strange, the video works for me...

i can try out a nightly. I think the last time I checked those weren't being built for arm, but looks like they are now.

i'll update this thread if the issue comes up again.

[Byron]

Thanks for the hint :) - it looks like Safari can't show it, but Chromium based browser are fine.

That definitely looks like a strange logic bug to me as the frontend seems to be in charge of deciding if the button is enabled or not, without consulting the backend.

Maybe @estib-vega has an intuition what it could be when looking at the video.

[swelborn]

Hello, I recorded this with the dev tools while it was happening. Would that output be helpful to provide? The files are quite large so I'd rather email them to someone.

[Byron]

That's a great idea - if the dev-tools recording also contains call stacks and state, that might be useful. If it's compressible and smaller than 25MB, I think it can be attached in a comment as well.

[swelborn]

gitbutler-recording-after-restart.json.xz.gz gitbutler-recording-before-restart.json.xz.gz

To compress small enough i had to use xz, but github doesn't support uploading files with that suffix.

So to get the data:

gunzip gitbutler-recording-before-restart.json.xz.gz
xz -d gitbutler-recording-before-restart.json.xz

gunzip gitbutler-recording-after-restart.json.xz.gz
xz -d gitbutler-recording-after-restart.json.xz

[Byron]

Thanks a lot! I was able to decompress the json file and import it into the safari dev tools. Maybe this helps, particularly if it would expose JS state.