gitbucket icon indicating copy to clipboard operation
gitbucket copied to clipboard
verified publisher icon gitbucket

add + in validate page name should return invalid charactor

Open mrgleam opened this issue 5 years ago • 4 comments

all issue 2412 that this PR should correct

Before submitting a pull-request to GitBucket I have first:

  • [ ] read the contribution guidelines
  • [ ] rebased my branch over master
  • [ ] verified that project is compiling
  • [ ] verified that tests are passing
  • [ ] squashed my commits as appropriate (keep several commits if it is relevant to understand the PR)
  • [ ] marked as closed using commit message all issue ID that this PR should correct

mrgleam avatar Jan 09 '20 07:01 mrgleam

Hmm... or is it really need to be decoded here? https://github.com/gitbucket/gitbucket/blob/f17f74c30badfe23c2fcce85a7213b7599fa01b1/src/main/scala/gitbucket/core/controller/WikiController.scala#L76

SIkebe avatar Jan 10 '20 12:01 SIkebe

#2412

SIkebe avatar Jan 10 '20 12:01 SIkebe

Hmm... or is it really need to be decoded here?

https://github.com/gitbucket/gitbucket/blob/f17f74c30badfe23c2fcce85a7213b7599fa01b1/src/main/scala/gitbucket/core/controller/WikiController.scala#L76

Line 76 Fixed Issue https://github.com/gitbucket/gitbucket/issues/35

I'm not sure.

mrgleam avatar Jan 10 '20 13:01 mrgleam

Line 76 Fixed Issue #35

Yeah, however current codebase seems to work without decoding...

image

SIkebe avatar Jan 10 '20 13:01 SIkebe