PptxGenJS icon indicating copy to clipboard operation
PptxGenJS copied to clipboard

added new connector type

Open lifejuggler opened this issue 4 years ago • 7 comments

added new options to allow users to add connector between shapes

lifejuggler avatar Jun 21 '20 22:06 lifejuggler

Question:

  1. I see that my indents are pretty messed up in here but it looks to be fine in my IDE. What is the spacing setting that is used?
  2. How do I include doc? I don't see any doc folder that I can modify to add information about connection usage

lifejuggler avatar Jun 21 '20 22:06 lifejuggler

@gitbrent I have updated my very old PR to fit the new TS updates done. Let me know what you think

lifejuggler avatar Jul 10 '20 02:07 lifejuggler

I like what you've done, but I need to think about how best to create and utilize source/target ids.

gitbrent avatar Dec 26 '20 20:12 gitbrent

sure @gitbrent , let me know what you'd think is the best way forward and I can adjust to your idea

lifejuggler avatar Dec 27 '20 04:12 lifejuggler

Happy to help with this PR if needed! What would be useful to do?

kachkaev avatar Mar 18 '21 13:03 kachkaev

I am still waiting on the author's idea @kachkaev @gitbrent

lifejuggler avatar Mar 18 '21 14:03 lifejuggler

Status update: I'm just sitting on this. Connectors are a fine addition, but i've been prioritizing more widely-used features...

gitbrent avatar Mar 24 '21 04:03 gitbrent

@gitbrent Is there any other reason this hasn't been merged? Are you waiting on anything in particular?

stefannew avatar Nov 22 '22 17:11 stefannew