Inline commenting in Ticket patchsets

[gitblit]

Originally reported on Google Code with ID 415

James, I must say the tickets feature is really showing promise, thanks for the excellent
additions so far.

Now I'd like to ask if you have any plans to implement some kind of inline commenting,
i.e. I can comment a specific line of code in the patchset so that the submitter instantly
knows which is the specific part that needs improvement/change. I mean, something similar
to that of other hosting/reviewing systems such as Gerrit, Review Board, Github, etc.
E.g.: http://rnbw.in/MDHiQ

Maybe the simplest way would be an extension to the current comments section, e.g.
we'd have the comment buttons (+ signs or anything) on each line and when one adds
a comment that'd be a regular commment except linked to this commit and line. So it's
more of a rendering change, i.e.

regular comment + commit/line id (comment prefix or something) = inline comment

What do you think?

Reported by [email protected] on 2014-04-29 14:05:13

[gitblit]

It's something I plan to do, but I have not spent any time working on it.  Something
like what you have described is what I had considered.

I try to keep things simple and try to stick with Git conventions when possible.  My
instinct is to try to base this off git-notes and use JSON to represent comment graphs.
 You can only have 1 git note per commit, I think.  That's why JSON - the git-note
would be an array of JSON comment objects.  The ticket page would collect comments
for the commits in the _current_ patchset and inject them as a graph amongst the ticket
comments.  Old/stale comments on rebased or amended commits would not be visible in
the default view of the ticket.

You approach is another possibility, store the commit comments in the ticket journal.
 In that design everything is encapsulated, and that may be the better approach.

Reported by James.Moger on 2014-04-29 14:21:25

[gitblit]

Thanks for the in-depth answer, James!

Reported by [email protected] on 2014-04-30 11:33:56

[felipesere]

@gitblit is there any update on this? Having inline comments on tickets would make GitBlit all the more valuable to us...

[gitblit]

This feature has not yet been developed and I can't say when it may land.