prettier-plugin-ember-template-tag icon indicating copy to clipboard operation
prettier-plugin-ember-template-tag copied to clipboard

Refactored code (Part 3)

Open ijlee2 opened this issue 7 months ago • 2 comments

Background

Prep work for #368.

I moved the existing code around so that we can simplify src/main.ts and the file structure better matches that in prettier-plugin-ember-hbs-tag.

/* src/main.ts */
export { languages } from './languages.js';
export { options } from './options.js';
export { parsers } from './parsers.js';
export { printers } from './printers.js';

ijlee2 avatar Jun 13 '25 08:06 ijlee2

@NullVoxPopuli Can you help with reviewing this PR and #368?

ijlee2 avatar Jun 19 '25 07:06 ijlee2

matches that in prettier-plugin-ember-hbs-tag

What's the benefit of doing this though?

Much of the content that code can just be deleted (in a separate pr), and would shrink this pr (yay!)

I do like smaller files tho!

NullVoxPopuli avatar Jun 19 '25 18:06 NullVoxPopuli

What's the benefit of doing this though?

Currently, the files don't practice a good separation of concerns. As a result, I think the package will feel more magical to contributors than it actually is. This, in return, would make maintaining and extending the package difficult.

ijlee2 avatar Dec 11 '25 12:12 ijlee2

I'm a fan of the new structure presented here

evoactivity avatar Dec 11 '25 13:12 evoactivity

Sorry @ijlee2, you'll have to rebase again 🙈

evoactivity avatar Dec 11 '25 15:12 evoactivity

Rebased.

ijlee2 avatar Dec 11 '25 17:12 ijlee2