HaloSharp icon indicating copy to clipboard operation
HaloSharp copied to clipboard

H5 spartan company endpoint

Open C-Kennelly opened this issue 8 years ago • 0 comments

Hey Damon! I needed access to the Company endpoints, so I thought I'd try my hand at extending HaloSharp for one of them. I've never contributed to a repo before, and this is my first time really digging into HaloSharp, so please let me know if I missed something important...

The endpoint I wanted to add was: https://developer.haloapi.com/docs/services/58acdc2e21091812784ce8c2/operations/5969689a2109180f287972a8

Here are the additions:

  • PlayerAppearance (model), with a "Company" model built in.
  • GetPlayerAppearance (query)
  • Unit tests for GetPlayerAppearance
  • Two json files for remaining unit tests.

For testing, I just modified test cases from "GetMatchResults", so it's probably not as thorough as it could be. Honestly, I'm just dipping my feet into testing.

Here's a simple classic desktop application to demo the results: https://gist.github.com/C-Kennelly/8a339e780f75993f6700d8263ec5ff2b

Would love to have it updated in the Nuget package so I can bring it into my bigger project if it checks out!

C-Kennelly avatar Aug 06 '17 20:08 C-Kennelly