WIP: Make "git archive gzip" stream the same as gzip

[cielavenir]

In https://github.com/git/git/commit/4f4be00d302bc52d0d9d5a3d4738bb525066c710 , git archive has been changed to use internal implementation. However, it caused different stream and a bunch of utilities were affected due to the checksum change. This pull request will fill the gap and generate the same stream as gzip.

Todos:

• [ ] Port the change to zlib 1.2.13, I used 1.2.11 due to some implementation change in 1.2.12
• [ ] Robust testing, there might be failing cases
• [ ] Actually, is it allowed to embed zlib into git? I noticed it because github action does not seem to download submodules.

Note that need to move cielavenir/zlib submodule to git/zlib before merging.

---

I'm getting busy nowadays, so I save my current state as WIP pull request so that others can see it.

---

Thanks for taking the time to contribute to Git! Please be advised that the Git community does not use github.com for their contributions. Instead, we use a mailing list ([email protected]) for code submissions, code reviews, and bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/) to conveniently send your Pull Requests commits to our mailing list.

Please read the "guidelines for contributing" linked above!

[gitgitgadget-git[bot]]

Welcome to GitGitGadget

Hi @cielavenir, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that your Pull Request has a good description, as it will be used as cover letter. You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <[email protected]>, Ill Takalook <[email protected]>

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join [email protected], where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

[gitgitgadget-git[bot]]

There are issues in commit 4772552c2ff88c3dc671058d93211385ae0f5d4c: add zlib submodule Commit checks stopped - the message is too short Commit not signed off

[gitgitgadget-git[bot]]

There are issues in commit de07143545962beb8ac7628c5fbc5c31b737b7ed: compile zlib Commit checks stopped - the message is too short Commit not signed off

[gitgitgadget-git[bot]]

There are issues in commit 5e5f22b8ec08175437df45ef57a70a22394fd480: update zlib Commit checks stopped - the message is too short Commit not signed off

[dscho]

/allow

[gitgitgadget-git[bot]]

User cielavenir is now allowed to use GitGitGadget.

[cielavenir]

(thank you for /allow-ing, I will get back when I'm not busy)

(also I'm wondering what email address to use)

[dscho]

Well, don't you know, you run into all kinds of interesting people all the time. Today, I researched .zstd support in 7-Zip and found https://github.com/cielavenir/p7zip... 😃

[YahyaMohamedYahya]

Elmatrwy

[YahyaMohamedYahya]

كيف يمكنني تسجيل دخول

[YahyaMohamedYahya]

• @

[YahyaMohamedYahya]

اللغه العربيه