git icon indicating copy to clipboard operation
git copied to clipboard

pathsec: make check for PATHSPEC_LITERAL more readable

Open AZero13 opened this issue 2 years ago • 11 comments

This check is designed to die if global_magic has the PATHSPEC_LITERAL and any other setting.

This can be written is a much more obvious way: if global_magic has PATHSPEC_LITERAL, it can only BE PATHSPEC_LITERAL, and if it isn't then there are other settings.

cc: "Kristoffer Haugsbakk" [email protected]

AZero13 avatar Feb 04 '23 18:02 AZero13

Submitted as [email protected]

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1453/AreaZR/redundant-v1

To fetch this version to local tag pr-git-1453/AreaZR/redundant-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1453/AreaZR/redundant-v1

gitgitgadget-git[bot] avatar Dec 18 '24 03:12 gitgitgadget-git[bot]

On the Git mailing list, "Kristoffer Haugsbakk" wrote (reply to this):

Commit subject area: s/pathsec/pathspec/

gitgitgadget-git[bot] avatar Dec 18 '24 04:12 gitgitgadget-git[bot]

User "Kristoffer Haugsbakk" <[email protected]> has been added to the cc: list.

gitgitgadget-git[bot] avatar Dec 18 '24 04:12 gitgitgadget-git[bot]

@dscho is there a way to like not be CC? Can I remove my email from the CC I just did the submit?

Not sign the commit or author it?

AZero13 avatar Dec 18 '24 05:12 AZero13

@dscho is there a way to like not be CC? Can I remove my email from the CC I just did the submit?

Not sign the commit or author it?

It is the Git project's rule that they want to know how to contact you in case of follow-up questions. Details are found e.g. here: https://git-scm.com/docs/SubmittingPatches#sign-off

dscho avatar Dec 18 '24 08:12 dscho

@dscho is there a way to like not be CC? Can I remove my email from the CC I just did the submit? Not sign the commit or author it?

It is the Git project's rule that they want to know how to contact you in case of follow-up questions. Details are found e.g. here: https://git-scm.com/docs/SubmittingPatches#sign-off

I was not talking about sign-offs I meant gitgadget CC the email of the person who did /submit

AZero13 avatar Dec 18 '24 17:12 AZero13

@dscho is there a way to like not be CC? Can I remove my email from the CC I just did the submit? Not sign the commit or author it?

It is the Git project's rule that they want to know how to contact you in case of follow-up questions. Details are found e.g. here: https://git-scm.com/docs/SubmittingPatches#sign-off

I was not talking about sign-offs I meant gitgadget CC the email of the person who did /submit

Like, that's how we got the problem of no-replies mixed in with the legit email.

AZero13 avatar Dec 18 '24 17:12 AZero13

@dscho is there a way to like not be CC? Can I remove my email from the CC I just did the submit? Not sign the commit or author it?

It is the Git project's rule that they want to know how to contact you in case of follow-up questions. Details are found e.g. here: https://git-scm.com/docs/SubmittingPatches#sign-off

like if i submit on behalf of someone else, I am CCed even though it should only include the email in the patch itself

AZero13 avatar Dec 18 '24 17:12 AZero13

If you are contributing the patch on someone else's behalf without GitGitGadget, you are still Cc:ed. That's the rule. I did not make that rule. You may want to discuss this with someone who made that rule.

dscho avatar Dec 18 '24 18:12 dscho

Ok

AZero13 avatar Dec 18 '24 20:12 AZero13

Ok

AZero13 avatar Dec 18 '24 20:12 AZero13