git.github.io icon indicating copy to clipboard operation
git.github.io copied to clipboard

fixed width that's lesser than the content width #472

Open Ananyasingh2002 opened this issue 2 years ago • 8 comments

The website's responsiveness was enhanced with "flex-wrap: wrap," and the layout adjustment at "@media (max-width: 993px)" ensures optimal display on various devices, creating a fully functional and user-friendly experience. Ensure code-blocks take-up fixed width that's lesser than the content width #472

Ananyasingh2002 avatar Oct 15 '23 07:10 Ananyasingh2002

Hey @Ananyasingh2002 ! Thanks for the MR. Unfortunately, I believe this fix results in the whole page rendering with a smaller font size. This results in poor readability on mobile screens. Here's a couple of screenshots for reference:

Before After
Screenshot_2023-10-16-00-32-24-28_d0ef7a9810af20f7b394f4f927b723b0 Screenshot_2023-10-15-22-57-05-54_d0ef7a9810af20f7b394f4f927b723b0

Could you kindly look into how to avoid this and ensure the page renders well and just the code block is made scrollable as mentioned in the issue ?

sivaraam avatar Oct 15 '23 19:10 sivaraam

I'll do it by tomorrow.

Ananyasingh2002 avatar Oct 18 '23 09:10 Ananyasingh2002

I have made changes to the font size, but there is an issue in the HTML code. Specifically, the list items under the 'Releases' header are not being affected by the font size increase. To address this, we need to add a class to the ul element immediately following the 'Releases' header.

Ananyasingh2002 avatar Oct 23 '23 18:10 Ananyasingh2002

I have made changes to the font size, but there is an issue in the HTML code.

Could you not apply the font size change for the whole body rather than specific headings and paragraphs ? 🤔

With the recent change, not just the list items, many headings also appear strangely sized. Further, the font of code-block also seems to shrink on small screen sizes. It would be ideal if the code block was just scrollable without affecting the font size.

Checkout this screenshot for reference

Screenshot_2023-10-30-00-33-51-93_d0ef7a9810af20f7b394f4f927b723b0

Also, the current site's styling is such that it renders well on most screen sizes without the need to do a right-left scroll. Could you kindly check the feasibilty of achieving the same in your changes too ? Let us know if there's anything that hinders that.

sivaraam avatar Oct 29 '23 19:10 sivaraam

When we change the font size of the body, it only affects the font size of the navbar. Therefore, I need to adjust the font size of specific headings and paragraphs separately.

Ananyasingh2002 avatar Oct 30 '23 05:10 Ananyasingh2002

Okay I'll do it.

Ananyasingh2002 avatar Oct 30 '23 05:10 Ananyasingh2002

Could you please assist me by informing me about how to join the Git community for GSoC updates?

Ananyasingh2002 avatar Oct 30 '23 05:10 Ananyasingh2002

@Ananyasingh2002 I think the best way to ask the community if you want GSoC updates is the Git mailing list (see https://git-scm.com/community). But the GSoC 2023 is over (see the first small article in https://git.github.io/rev_news/2023/09/30/edition-103/), and nothing is known yet about GSoC 2024.

chriscool avatar Oct 30 '23 07:10 chriscool