git-scm.com icon indicating copy to clipboard operation
git-scm.com copied to clipboard

fixed: ordering of videos has been fixed at: /videos to show episodes in correct order

Open Paulie-Aditya opened this issue 4 months ago • 6 comments

Changes

Simply flipped over the conditions and that fixed it

in the left column: episodes 1 and 3 in the right column: episodes 2 and 4

Context

@To1ne brought this issue up once, that the video ordering on : https://git-scm.com/videos is wrong. Specifically, episodes 2 and 4 are in the left column and the episodes 1 and 3 are in the right column.

Paulie-Aditya avatar Sep 19 '25 13:09 Paulie-Aditya

@To1ne Kindly let me know if the commit message is now appropriately defined, if not kindly guide me in the right direction for the same as well, would be more than happy to understand and contribute more meaningfully! Cheers!

Paulie-Aditya avatar Sep 19 '25 13:09 Paulie-Aditya

@Paulie-Aditya Let me suggest something like:

fix ordering of videos

The videos are shown in a grid view. This is done by showing them in two
columns. But during implementation the columns where swapped.

Reorder the columns so the top left video is the first of the series.

Some notes from this:

  • Start with a title, prefer to stay below 72 chars
  • Followed by an empty line
  • Then explain what the problem is (wrap lines at 80 chars)
  • Then explain what you're changing

But I've noticed something else. On mobile (small screens) the order is still wrong. We should switch to CSS grid or flexbox to make sure the order is persisted across viewports.

To1ne avatar Sep 26 '25 07:09 To1ne

Okay, will do the changes as instructed, thanks for the guidance!

Paulie-Aditya avatar Sep 26 '25 16:09 Paulie-Aditya

I find it very nice to see progress here! Unfortunately, these changes are way over my head, so I cannot contribute to the review 😞

dscho avatar Sep 30 '25 07:09 dscho

sorry been pre-occupied, will definitely implement these soon.

Paulie-Aditya avatar Oct 09 '25 19:10 Paulie-Aditya

sorry been pre-occupied, will definitely implement these soon.

No worries, we all got stuff to do. :purple_heart:

To1ne avatar Oct 10 '25 19:10 To1ne